« Updates not a go-go | Main | Oh What Fun it is to.. »
August 13, 2004
PHPs odbc_fetch functions
Dave Lawson had sent out a patch a little while ago on the php-internals list with a collection of patches for the ODBC system. He basically took out the useless ID numbering system ODBC has in place relying upon the system in Zend for resource management, and a second patch that forces a ecalloc instead of an emalloc for the SQLExtendedFetch failure points.
While the first is something I've toyed with doing a lot, I've just never felt it was that big a deal really to bother with it. The second patch is one I'm not entirely sure about. While his patch works fine, I think the basic assumption and means to correcting it are not the best possible path. Mainly because it forces a reliance upon the behavior of a section of code instead of being reliant upon the return status/codes of a series of functions. Regardless, it needs testing and due to circumstances beyond my control I cannot test it completely/throughly at the moment. As such, I've committed the ecalloc patch for testing and use in the generated snapshots. Hopefully if something is not working, someone will email me and let me know. Platform of interest is MS Access, which has historically been the most finicky of the ODBC systems.
Oh yeah, I should mention that it's not that the ecalloc patch is wrong or going to be harmful in anyway at the moment. In fact, for what it does, it's really quite a nice temporary solution to a more systemic problem of the ODBC module. My point of concern with it comes from future evolution of the ODBC module, where this behavior may not be assured, or more importantly not recognized/remembered when extending the ODBC module.
Posted by Dan at August 13, 2004 06:16 PM